Author: sebb
Date: Fri May 18 17:05:37 2007
New Revision: 539644

URL: http://svn.apache.org/viewvc?view=rev&rev=539644
Log:
Improved error handling

Modified:
    
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/ResultCollector.java

Modified: 
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/ResultCollector.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/ResultCollector.java?view=diff&rev=539644&r1=539643&r2=539644
==============================================================================
--- 
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/ResultCollector.java
 (original)
+++ 
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/reporters/ResultCollector.java
 Fri May 18 17:05:37 2007
@@ -60,6 +60,7 @@
 import org.apache.jmeter.testelement.property.BooleanProperty;
 import org.apache.jmeter.testelement.property.ObjectProperty;
 import org.apache.jorphan.logging.LoggingManager;
+import org.apache.jorphan.util.JMeterError;
 import org.apache.jorphan.util.JOrphanUtils;
 import org.apache.log.Logger;
 import org.xml.sax.SAXException;
@@ -202,7 +203,7 @@
                             try {
                                 SampleResult result = 
OldSaveService.makeResultFromDelimitedString(line);
                                 if (result != null) sendToVisualizer(result);
-                            } catch (NumberFormatException ignored){
+                            } catch (NumberFormatException ignored){//TODO - 
why ignore these?
                                 errorDetected = true;
                             }
                             line = dataReader.readLine();
@@ -230,14 +231,16 @@
                     }
                 }
                        } catch (IOException e) {
-                log.warn("Problem reading JTL file "+e.getLocalizedMessage());
+                log.warn("Problem reading JTL file: "+file);
+                       } catch (JMeterError e){
+                log.warn("Problem reading JTL file: "+file);
             } finally {
                 JOrphanUtils.closeQuietly(dataReader);
                 JOrphanUtils.closeQuietly(bufferedInputStream);
                                if (!parsedOK || errorDetected) {
                     GuiPackage.showErrorMessage(
                                 "Error loading results file - see log file",
-                                "CSV Result file loader");
+                                "Result file loader");
                                }
                        }
                }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to