Author: sebb
Date: Sat Oct 20 07:05:12 2007
New Revision: 586722
URL: http://svn.apache.org/viewvc?rev=586722&view=rev
Log:
Clarify TODOs
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java?rev=586722&r1=586721&r2=586722&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
Sat Oct 20 07:05:12 2007
@@ -279,8 +279,8 @@
String hfk;
for (int i = 1; (hfk=conn.getHeaderFieldKey(i)) != null; i++) {
- // TODO - why is this not saved? A: it might be a proxy server
specific field.
- // If JMeter is using a proxy, the browser wouldn't know about
that.
+ // TODO: Handle this in Proxy instead?
+ // As this has already been handled, it is currently
removed to avoid confusing the JMeter Proxy
if (!TRANSFER_ENCODING.equalsIgnoreCase(hfk)) {
headerBuf.append(hfk);
headerBuf.append(": "); // $NON-NLS-1$
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java?rev=586722&r1=586721&r2=586722&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
Sat Oct 20 07:05:12 2007
@@ -604,8 +604,9 @@
for (int i = 0; i < rh.length; i++) {
String key = rh[i].getName();
+ // TODO: Handle this in Proxy instead?
+ // As this has already been handled, it is currently
removed to avoid confusing the JMeter Proxy
if (!key.equalsIgnoreCase(TRANSFER_ENCODING))
- // TODO - why is this not saved?
{
headerBuf.append(key);
headerBuf.append(": "); // $NON-NLS-1$
@@ -1013,7 +1014,7 @@
* Class extending FilePart, so that we can send placeholder text
* instead of the actual file content
*/
- private class ViewableFilePart extends FilePart {
+ private static class ViewableFilePart extends FilePart {
private boolean hideFileData;
public ViewableFilePart(String name, File file, String contentType,
String charset) throws FileNotFoundException {
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
