Author: sebb
Date: Tue Jan 8 04:14:17 2008
New Revision: 609949
URL: http://svn.apache.org/viewvc?rev=609949&view=rev
Log:
Tidy Exception handling and logging
Modified:
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java
Modified:
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java?rev=609949&r1=609948&r2=609949&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java
Tue Jan 8 04:14:17 2008
@@ -26,8 +26,6 @@
/**
* Receiver of pseudo-synchronous reply messages.
*
- * @author Martijn Blankestijn
- * @version $Id$.
*/
public class Receiver implements Runnable {
private boolean active;
@@ -39,19 +37,15 @@
private QueueConnection conn;
// private static Receiver receiver;
- static Logger log = LoggingManager.getLoggerForClass();
+ private static final Logger log = LoggingManager.getLoggerForClass();
private Receiver(QueueConnectionFactory factory, Queue receiveQueue)
throws JMSException {
conn = factory.createQueueConnection();
session = conn.createQueueSession(false,
Session.AUTO_ACKNOWLEDGE);
consumer = session.createReceiver(receiveQueue);
- if (log.isDebugEnabled()) {
- log.debug("Receiver - ctor. Starting connection now");
- }
+ log.debug("Receiver - ctor. Starting connection now");
conn.start();
- if (log.isInfoEnabled()) {
- log.info("Receiver - ctor. Connection to messaging
system established");
- }
+ log.info("Receiver - ctor. Connection to messaging system
established");
}
public static synchronized Receiver
createReceiver(QueueConnectionFactory factory, Queue receiveQueue)
@@ -86,17 +80,22 @@
}
} catch (JMSException e1) {
- e1.printStackTrace();
+ log.error("Error handling receive",e1);
}
}
// not active anymore
if (session != null) {
try {
session.close();
- if (conn != null)
- conn.close();
+ try {
+ if (conn != null) {
+ conn.close();
+ }
+ } catch (JMSException e) {
+ log.error("Error closing connection",e);
+ }
} catch (JMSException e) {
- e.printStackTrace();
+ log.error("Error closing session",e);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
