svn commit: r609956 - /jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java

[sebb]

Author: sebb
Date: Tue Jan  8 04:36:56 2008
New Revision: 609956

URL: http://svn.apache.org/viewvc?rev=609956&view=rev
Log:
Replace printStackTrace with log message

Modified:
    
jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java

Modified: 
jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java?rev=609956&r1=609955&r2=609956&view=diff
==============================================================================
--- 
jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
 (original)
+++ 
jakarta/jmeter/trunk/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
 Tue Jan  8 04:36:56 2008
@@ -29,9 +29,14 @@
 import org.apache.jmeter.monitor.model.ObjectFactory;
 import org.apache.jmeter.monitor.model.Status;
 import org.apache.jmeter.samplers.SampleResult;
+import org.apache.jorphan.logging.LoggingManager;
+import org.apache.log.Logger;
 
 public abstract class ParserImpl implements Parser {
-       private SAXParserFactory PARSERFACTORY = null;
+    
+       private static final Logger log = LoggingManager.getLoggerForClass();
+
+    private SAXParserFactory PARSERFACTORY = null;
 
        private SAXParser PARSER = null;
 
@@ -51,11 +56,9 @@
                        DOCHANDLER = new MonitorHandler();
                        DOCHANDLER.setObjectFactory(this.FACTORY);
                } catch (SAXException e) {
-                       // e.printStackTrace();
-                       // need to add logging later
+                       log.error("Failed to create the parser",e);
                } catch (ParserConfigurationException e) {
-                       // e.printStackTrace();
-                       // need to add logging later
+                       log.error("Failed to create the parser",e);
                }
        }
 
@@ -72,11 +75,11 @@
                        PARSER.parse(is, DOCHANDLER);
                        return DOCHANDLER.getContents();
                } catch (SAXException e) {
-                       e.printStackTrace();
+                       log.error("Failed to parse the bytes",e);
                        // let bad input fail silently
                        return DOCHANDLER.getContents();
-               } catch (IOException e) {
-                       e.printStackTrace();
+               } catch (IOException e) { // Should never happen
+                       log.error("Failed to read the bytes",e);
                        // let bad input fail silently
                        return DOCHANDLER.getContents();
                }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]