Author: sebb
Date: Thu Jun 26 13:53:52 2008
New Revision: 672028

URL: http://svn.apache.org/viewvc?rev=672028&view=rev
Log:
The test element "Save Results to a file" is now shown as a Listener.

Modified:
    
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
    jakarta/jmeter/trunk/xdocs/changes.xml
    jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml

Modified: 
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java?rev=672028&r1=672027&r2=672028&view=diff
==============================================================================
--- 
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
 (original)
+++ 
jakarta/jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultSaverGui.java
 Thu Jun 26 13:53:52 2008
@@ -28,16 +28,16 @@
 
 import org.apache.jmeter.reporters.ResultSaver;
 import org.apache.jmeter.samplers.Clearable;
-import org.apache.jmeter.processor.gui.AbstractPostProcessorGui;
 import org.apache.jmeter.testelement.TestElement;
 import org.apache.jmeter.util.JMeterUtils;
+import org.apache.jmeter.visualizers.gui.AbstractListenerGui;
 
 /**
  * Create a ResultSaver test element, which saves the sample information in set
  * of files
  * 
  */
-public class ResultSaverGui extends AbstractPostProcessorGui implements 
Clearable {
+public class ResultSaverGui extends AbstractListenerGui implements Clearable {
 
        private JTextField filename;
 
@@ -104,17 +104,15 @@
                setBorder(makeBorder());
                Box box = Box.createVerticalBox();
                box.add(makeTitlePanel());
-               box.add(createFilenamePanel());
+               box.add(createFilenamePrefixPanel());
                errorsOnly = new 
JCheckBox(JMeterUtils.getResString("resultsaver_errors")); // $NON-NLS-1$
                box.add(errorsOnly);
         successOnly = new 
JCheckBox(JMeterUtils.getResString("resultsaver_success")); // $NON-NLS-1$
         box.add(successOnly);
                add(box, BorderLayout.NORTH);
-
-               // add(makeTitlePanel(),BorderLayout.NORTH);
        }
 
-       private JPanel createFilenamePanel()// TODO ought to be a FileChooser 
...
+       private JPanel createFilenamePrefixPanel()
        {
                JLabel label = new 
JLabel(JMeterUtils.getResString("resultsaver_prefix")); // $NON-NLS-1$
 

Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=672028&r1=672027&r2=672028&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Thu Jun 26 13:53:52 2008
@@ -38,17 +38,17 @@
 <h4>Bug fixes</h4>
 <p>
 <ul>
-<li>Prompt to overwrite existing file when saving a new test plan</li>
 </ul>
 </p>
 
 <h4>Improvements</h4>
 <p>
 <ul>
-<li>Add OUT variable to jexl function</li>
 </ul>
 </p>
 
+<!--  ========================= End of summary 
===================================== -->
+
 <h3>Known bugs</h3>
 
 <p>
@@ -65,19 +65,29 @@
 </p>
 <h3>Incompatible changes</h3>
 <ul>
+The test element "Save Results to a file" is now shown as a Listener.
+It was previously shown as a Post-Processor, even though it was in fact a 
Listener.
+This change only affects the icon that is displayed and the location in the 
Gui pop-up menus.
+It does not affect test plans or test behaviour.
 </ul>
 
 <h3>Bug fixes</h3>
 <ul>
 <li>Bug 45199 - don't try to replace blank variables in Proxy recording</li>
+<li>The "prev" and "sampler" objects are now defined for BSF test elements</li>
+<li>Prompt to overwrite an existing file when first saving a new test plan</li>
+<li>The test element "Save Results to a file" is now shown as a Listener</li>
 </ul>
 
 <h3>Improvements</h3>
 <ul>
+<li>LDAP result data now formatted with line breaks</li>
+<li>Add OUT variable to jexl function</li>
 </ul>
 
 <h3>Non-functional changes</h3>
 <ul>
+Introduce AbstractListenerGui class to make it easier to create Listeners with 
no visual output
 </ul>
 </section> 
 </body> 

Modified: jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=672028&r1=672027&r2=672028&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
+++ jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml Thu Jun 26 
13:53:52 2008
@@ -2143,6 +2143,30 @@
 </div>
 </component>
 
+<component name="Save Responses to a file" index="&sect-num;.3.16"  
width="361" height="165" screenshot="savetofile.png">
+    <description>
+        <p>
+        This test element can be placed anywhere in the test plan.
+        For each sample in its scope, it will create a file of the response 
Data.
+        The primary use for this is in creating functional tests.
+        The file name is created from the specified prefix, plus a number.
+        The file extension is created from the document type, if known.
+        If not known, the file extension is set to 'unknown'.
+        The generated file name is stored in the sample response, and can be 
saved
+        in the test log output file if required.
+        </p>
+        <p>
+        The current sample is saved first, followed by any sub-samples (child 
samples).
+        </p>
+    </description>
+ <properties>
+ <property name="Name" required="No">Descriptive name for this element that is 
shown in the tree.</property>
+ <property name="Filename Prefix" required="Yes">Prefix for the generated file 
names; this can include a directory name.</property>
+ <property name="Save Failed Responses only" required="Yes">If selected, then 
only failed responses are saved</property>
+ <property name="Save Successful Responses only" required="Yes">If selected, 
then only successful responses are saved</property>
+ </properties>
+</component>
+
 
 <a href="#">^</a>
 
@@ -3515,31 +3539,7 @@
    </properties>
 </component>
 
-<component name="Save Responses to a file" index="&sect-num;.8.4"  width="361" 
height="165" screenshot="savetofile.png">
-       <description>
-           <p>
-           This test element can be placed anywhere in the test plan.
-               For each sample in its scope, it will create a file of the 
response Data.
-               The primary use for this is in creating functional tests.
-               The file name is created from the specified prefix, plus a 
number.
-               The file extension is created from the document type, if known.
-               If not known, the file extension is set to 'unknown'.
-               The generated file name is stored in the sample response, and 
can be saved
-               in the test log output file if required.
-               </p>
-               <p>
-               The current sample is saved first, followed by any sub-samples 
(child samples).
-               </p>
-       </description>
- <properties>
- <property name="Name" required="No">Descriptive name for this element that is 
shown in the tree.</property>
- <property name="Filename Prefix" required="Yes">Prefix for the generated file 
names; this can include a directory name.</property>
- <property name="Save Failed Responses only" required="Yes">If selected, then 
only failed responses are saved</property>
- <property name="Save Successful Responses only" required="Yes">If selected, 
then only successful responses are saved</property>
- </properties>
-</component>
-
-<component name="Generate Summary Results" index="&sect-num;.8.5"  width="358" 
height="131" screenshot="summary.png">
+<component name="Generate Summary Results" index="&sect-num;.8.4"  width="358" 
height="131" screenshot="summary.png">
        <description>This test element can be placed anywhere in the test plan.
 Generates a summary of the test run so far to the log file and/or 
 standard output. Both running and differential totals are shown.
@@ -3586,7 +3586,7 @@
  </properties>
 </component>
 
-<component name="BeanShell PostProcessor"  index="&sect-num;.8.6"  width="597" 
height="303" screenshot="beanshell_postprocessor.png">
+<component name="BeanShell PostProcessor"  index="&sect-num;.8.5"  width="597" 
height="303" screenshot="beanshell_postprocessor.png">
 <description>
 <p>
 The BeanShell PreProcessor allows arbitrary code to be applied after taking a 
sample.
@@ -3632,7 +3632,7 @@
 <p>If the property <b>beanshell.postprocessor.init</b> is defined, this is 
used to load an initialisation file, which can be used to define methods etc 
for use in the BeanShell script.</p>
 </component>
 
-<component name="BSF PostProcessor" index="&sect-num;.8.7"  width="529" 
height="382" screenshot="bsf_postprocessor.png">
+<component name="BSF PostProcessor" index="&sect-num;.8.6"  width="529" 
height="382" screenshot="bsf_postprocessor.png">
 <description>
 <p>
 The BSF PostProcessor allows BSF script code to be applied after taking a 
sample.



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to