On 05/11/2008, Oghie Sheehy <[EMAIL PROTECTED]> wrote: > > I've just started looking at the code. Looks good, but there are a > > couple of areas which I think need tweaking. > > > BinaryTCPClientImpl uses eolByte which is set from the property > tcp.eolByte. > > I'm not sure that this is needed - does it make sense for a binary > > protocol to have an End of Line byte? If so, then the property name > > needs to be changed, otherwise one cannot mix TCP implementations in a > > test plan. > > Yes, eol does not make sense in a binary protocol but I think an end of > message byte would. So the property name would need to be changed. >
OK, I'll do that. The eolByte methods are part of the interface so the name cannot be changed, but I will update the Javadoc. > > > I'm not entirely sure why LengthPrefixedBinaryTCPClientImpl does not > > extend BinaryTCPClientImpl instead of decorating it? > > General idea was that the length prefixing would be independent of protocol > data to allow binary length followed by character data and character length > followed by character data. This was why length prefix handling methods were > left in the decorator rather than in a direct subclass. Probably unnecessary > and no problem if it becomes a direct subclass. > OK, understood. I'll add a bit more to the Javadoc. I've added the initial implementations of the code to SVN, and will now work on the fixes mentioned above. > > > -----Original Message----- > From: sebb [mailto:[EMAIL PROTECTED] > > Sent: 04 November 2008 20:17 > To: JMeter Developers List > Subject: Re: FW: TCP Sampler Extension to support length-prefixed binary > data > > > > On 17/10/2008, Oghie Sheehy <[EMAIL PROTECTED]> wrote: > > Thanks, have created enhancement bug 46030 and attached source to it. > > > > I've just started looking at the code. Looks good, but there are a > couple of areas which I think need tweaking. > > BinaryTCPClientImpl uses eolByte which is set from the property tcp.eolByte. > I'm not sure that this is needed - does it make sense for a binary > protocol to have an End of Line byte? If so, then the property name > needs to be changed, otherwise one cannot mix TCP implementations in a > test plan. > > I'm not entirely sure why LengthPrefixedBinaryTCPClientImpl does not > extend BinaryTCPClientImpl instead of decorating it? > > <snip> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > ********************************************************************** > > E-mail disclaimer > FEXCO Dynamic Currency Conversion Limited, registered in Ireland, No. > 246289. Registered Office: FEXCO Centre, Iveragh Road, Killorglin, Co. Kerry. > > This message, including any attachments, is confidential. If you are not the > named recipient, please contact the sender and delete the email from your > system. > > ********************************************************************** > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
