Author: sebb Date: Wed Jan 28 14:58:28 2009 New Revision: 738505 URL: http://svn.apache.org/viewvc?rev=738505&view=rev Log: Mailer Visualiser - fix parsing of multiple e-mail address when using Test button
Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java jakarta/jmeter/trunk/xdocs/changes.xml jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java?rev=738505&r1=738504&r2=738505&view=diff ============================================================================== --- jakarta/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java (original) +++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java Wed Jan 28 14:58:28 2009 @@ -115,24 +115,23 @@ * @return a Vector of String-objects wherein each String represents a * mail-address. */ - public synchronized Vector getAddressVector() { - String theAddressie = getToAddress(); + public Vector getAddressVector() { + String addressees = getToAddress(); Vector addressVector = new Vector(); - if (theAddressie != null) { - String addressSep = ","; //$NON-NLS-1$ + if (addressees != null) { - StringTokenizer next = new StringTokenizer(theAddressie, addressSep); + StringTokenizer next = new StringTokenizer(addressees, ","); //$NON-NLS-1$ while (next.hasMoreTokens()) { String theToken = next.nextToken().trim(); if (theToken.indexOf("@") > 0) { //$NON-NLS-1$ addressVector.addElement(theToken); + } else { + log.warn("Ignored unexpected e-mail address: "+theToken); } } - } else { - return new Vector(0); } return addressVector; @@ -289,10 +288,7 @@ log.info(attText); - Vector destination = new Vector(); - destination.add(to); - - sendMail(from, destination, subject, attText, smtpHost); + sendMail(from, getAddressVector(), subject, attText, smtpHost); log.info("Test mail sent successfully!!"); } Modified: jakarta/jmeter/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=738505&r1=738504&r2=738505&view=diff ============================================================================== --- jakarta/jmeter/trunk/xdocs/changes.xml (original) +++ jakarta/jmeter/trunk/xdocs/changes.xml Wed Jan 28 14:58:28 2009 @@ -182,6 +182,8 @@ <li>Bug 46522 - Incorrect "Response data" in JDBC sample when column names are missing</li> <li>Bug 46424 - corrections to French translation</li> <li>Bug 46436 - Improve error reporting in Proxy Gui</li> +<li>Fix potential thread safety issue in JMeterThread class</li> +<li>Mailer Visualiser - fix parsing of multiple e-mail address when using Test button</li> </ul> <h3>Improvements</h3> Modified: jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=738505&r1=738504&r2=738505&view=diff ============================================================================== --- jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml (original) +++ jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml Wed Jan 28 14:58:28 2009 @@ -2191,7 +2191,7 @@ <properties> <property name="Name" required="No">Descriptive name for this element that is shown in the tree.</property> <property name="From" required="Yes">Email address to send messages from.</property> - <property name="Addressie(s)" required="Yes">Email address to send messages to.</property> + <property name="Addressee(s)" required="Yes">Email address to send messages to, comma-separated.</property> <property name="SMTP Host" required="No">IP address or host name of SMTP (email redirector) server.</property> <property name="Failure Subject" required="No">Email subject line for fail messages.</property> --------------------------------------------------------------------- To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org