Author: sebb
Date: Fri Mar 13 14:57:00 2009
New Revision: 753291
URL: http://svn.apache.org/viewvc?rev=753291&view=rev
Log:
Document cookie match policy
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
URL:
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java?rev=753291&r1=753290&r2=753291&view=diff
==============================================================================
---
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
(original)
+++
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
Fri Mar 13 14:57:00 2009
@@ -425,6 +425,14 @@
}
}
+ /**
+ * Check if cookies match, i.e. name, path and domain are equal.
+ * <br/>
+ * TODO - should we compare secure too?
+ * @param a
+ * @param b
+ * @return true if cookies match
+ */
private boolean match(Cookie a, Cookie b){
return
a.getName().equals(b.getName())
@@ -439,7 +447,7 @@
PropertyIterator iter = getCookies().iterator();
while (iter.hasNext()) {
Cookie cookie = (Cookie) iter.next().getObjectValue();
- if (cookie == null) {
+ if (cookie == null) {// TODO is this possible?
continue;
}
if (match(cookie,newCookie)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org
