https://issues.apache.org/bugzilla/show_bug.cgi?id=47290
Summary: Infinite loop on connection factory lookup
Product: JMeter
Version: Nightly (Please specify date)
Platform: PC
OS/Version: Windows Vista
Status: NEW
Severity: normal
Priority: P2
Component: Main
AssignedTo: jmeter-dev@jakarta.apache.org
ReportedBy: cafed...@gmail.com
Created an attachment (id=23732)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23732)
Patch for protocol.jms.client.ConnectionFactory
I screwed up when I defined the JNDI information for JMS Publisher/Subscriber
samplers. When I ran the test script JMeter seemed to hang. I could also hear
my disk rattling. I had to kill the process. I went to jmeter.log to see what
the problem was an noticed that it was 1GB in size! That lead me to the code in
...protocol.jms.client.ConnectionFactory, where to my amazement there was an
infinite loop - the lookup method looped generating error log entries until if
found the connection factory. Unfortunately, whoever coded this method
originally left no clue as to why there was an infinite loop here.
The patch that is attached assumes that the original coder had a valid reason
for retrying the lookup if it failed the first time. But it also places a limit
on the amount of time spent in doing a lookup and pauses between each attempt.
Personally, I would rather have aborted after the first lookup failed, but I
gave the original coder the benefit of the doubt and thus assumed that the
retry was done for a purpose.
Needless to say, I added comments that explain exactly why the method is now
coded the way it. This will help the next poor soul who stumbles across this
code and wonders why it does what it does. I wish that all code was commented
this way. I know that I demand it of all the people who work on projects with
me.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org
