Author: sebb
Date: Sat Jun 20 22:37:31 2009
New Revision: 786923

URL: http://svn.apache.org/viewvc?rev=786923&view=rev
Log:
IOException is not fatal; improved error handling

Modified:
    
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java

Modified: 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
URL: 
http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java?rev=786923&r1=786922&r2=786923&view=diff
==============================================================================
--- 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
 (original)
+++ 
jakarta/jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
 Sat Jun 20 22:37:31 2009
@@ -104,10 +104,14 @@
         try{
             Document d = parseResponse(previousResult);
             getValuesForXPath(d,getXPathQuery(),vars, refName);
-        }catch(IOException e){// Should not happen
-            final String errorMessage = "error on ("+getXPathQuery()+")";
+        }catch(IOException e){// e.g. DTD not reachable
+            final String errorMessage = "IOException on ("+getXPathQuery()+")";
             log.error(errorMessage,e);
-            throw new JMeterError(errorMessage,e);
+            AssertionResult ass = new AssertionResult("IOException"); // 
$NON-NLS-1$
+            ass.setFailure(true);
+            ass.setFailureMessage(e.getLocalizedMessage());
+            previousResult.addAssertionResult(ass);
+            previousResult.setSuccessful(false);
         } catch (ParserConfigurationException e) {// Should not happen
             final String errrorMessage = "error on ("+getXPathQuery()+")";
             log.error(errrorMessage,e);
@@ -119,7 +123,7 @@
         } catch (TidyException e) {
             AssertionResult ass = new AssertionResult("TidyException"); // 
$NON-NLS-1$
             ass.setFailure(true);
-            ass.setFailureMessage(e.getMessage());
+            ass.setFailureMessage(e.getLocalizedMessage());
             previousResult.addAssertionResult(ass);
             previousResult.setSuccessful(false);
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-h...@jakarta.apache.org

Reply via email to