Thanks for that.  I have just attached a patch there (from current CVS).

Here are my comments (copied from the bug report)

I have just attached a patch for this that does the following:
   * In ThreadGroup, add a threadStopped() that keeps track of which threads have 
stopped.  When there are zero threads left, this
method calls ThreadGroup.SampleQueue.stop(), which causes the thread in SampleQueue to 
exit.
   * In JMeterThread, when the run() method finishes, call group.threadStopped() to 
indicate the thread has finished.

There is also a patch for nongui.bat to make it work.

Note that this patch assumes that each JMeterThread object is run once and only once.  
At the moment ThreadGroup.threadCount() that
is responsible for counting the number of threads in a group, is called in the 
JMeterThread constructor.  Perhaps this would be
better at the start of the run() method.  There is also the possibility of moving the 
group.threadStopped() call to a finally block
in the run method.

I've only just started looking at the code so have done the bare minimum for now.

trust that someone can apply this, or tell me whats wrong with it (we're using it 
here).

cheers
dim

----- Original Message -----
From: "Martin Ramshaw" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Wednesday, April 24, 2002 8:32 AM
Subject: Re: NonGuiDriver - not exiting


> Check Bug report 5697:
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6597
>
> Later.
>
> Regards
>
>
> --
> To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
>


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to