On 22/09/2009, Rick <[email protected]> wrote: > I was just looking at some of the source code in trunk and I noticed > for instance that several of the methods in JavaSampler have code > like: > > log.debug(whoAmI() + "\trunTest"); > > From my understanding without an if (log.isDebugEnabled() ) check > before that statement, whoAmI() will ALWAYS be called even though its > output is not displayed (assuming log level above debug.) For > performance reasons, I'd think log.debug statements that involve some > concatenation of fields that need evaluation should be prefaced with > an if 'log.isDebugEnabled' check ? >
Yes, that would be better. Patches (via Bugzilla) welcome. > -- > Rick R > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
