Bugs item #927394, was opened at 2004-04-01 12:18
Message generated for change (Comment added) made by michaelthoward
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=927394&group_id=23629

Category: Applet
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nathana�l Mazuir (mlemaudit)
>Assigned to: Michael T Howard (michaelthoward)
Summary: package confusion ?

Initial Comment:
It seems that there is a little problem with some Jmol 
classes (CVS HEAD) :

1- In the package "org.openscience.jmol.applet" :

- The package declaration line is missing in the 
Jvm12.java file.


2- In the default package (i.e. in the src folder) :

- The Jvm12 Constructor is not visible from the default 
package.


Proposal to fix the problem :

1- Move these files to the "org.openscience.jmol.applet" 
package :

- JmolApplet.java
- JmolAppletControl.java
- JmolAppletRegistry.java

2- Add the missing package declaration line to all the 
files within the "org.openscience.jmol.applet" package.

Yours.
M.

----------------------------------------------------------------------

>Comment By: Michael T Howard (michaelthoward)
Date: 2004-04-01 13:02

Message:
Logged In: YES 
user_id=608250

Very good points. And thank you for filing this. 

I have fixed and checked in the changes to Jvm12

JmolApplet and JmolAppletControl are in the root for a good
reason. When a person wants to create an instance of the
applet they need to put the classname in their HTML file. By
putting these in the root someone can say
  <applet code="JmolApplet" ... >

instead of
  <applet code="org.openscience.jmol.applet.JmolApplet" ...>

I think there is significant benefit in simplifying the code
for the applet users. 

Does that make sense? 

I would like to move the JmolAppletRegistry into the
jmol.applet package, but I do not know how to import a class
that does not exist in a package. 

Any suggestions? 

Thanks again for taking the time to file this. 
Miguel


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=927394&group_id=23629


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Jmol-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to