Miguel & Rene wrote: >> Or am I missing something here? > > I think so :-)
Actually, I think everything you had was good. >> Maybe we should keep an instance of it in the SmarterModelAdapter class? >> >> I did commit what I did, so you can see it. > > OK, I will take a look. > > I may make some changes and check them in ... so you should refrain from > making any more mods until I send you another email. I checked in a bunch of changes: ModelResolver.java -> Resolver.java ModelAdapter.java -> JmolAdapter.java SmarterModelAdapter.java -> SmarterJmolAdapter.java CdkModelAdapter.java -> CdkJmolAdapter.java FrameExporetModelAdapter.java -> FrameExportJmolAdapter.java In JmolAdapter.java: - all uses of the word "model" are gone from methods and variables - we now have getAtomSetCount(), getAtomSetNumber(), getAtomSetName(), and getAtomSetProperties() These are generally not implemented. References to "Model" in the AtomIterator have been renamed to AtomSet. Within the org.jmol.adapter.smarter package I did not change most of the variable names that contain 'model' ... that is your job. I am no longer working on these files and you can work on them. Finally, I uncovered something that is important. The AtomSetCollection class does not have support for atomSetCount. We *must* add this. But it may require touching several Reader implementations ... so I need to think about the best way to do it. Miguel ----- Open Source Molecular Visualization www.jmol.org [EMAIL PROTECTED] ----- ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
