Miguel wrote:
Here's a recrafted documentation statement:
An atom is "visible" if the atom is in a displayed frame and one of
the following is true:
a. it has spacefill > 0
b. it has wireframe > 0
c. it has a halo highlight
d. it has a star highlight
e. it is part of a displayed backbone
f. it is part of a displayed nucleic acid base cartoon
I am very uncomfortable with this.
There is too much integration between the rendering code and the atom
expressions.
I'm sorry, (b) is nonsense. Atoms don't have wireframe settings. That
should read:
a. it has spacefill > 0
b. it has a displayed selection halo
c. it has a star highlight
d. it is part of a displayed bond
e. it is part of a displayed backbone
f. it is part of a displayed nucleic acid base cartoon
I agree completely that the fact that the rendering code is feeding
back settings to Atom is not optimal -- I can see where it may be
optimized for speed, because it's all overhead, and it does sort of
seem sensible to me to leave all the overhead to the end, when the
actual rendering occurs, but still....
At the same time, this seems to me a pretty good list -- it does in
fact account for all situations I can think of where an actual atom is
visible. Or at least we can let Eric now decide if that is the case.
So the trick will be to pull this sort of thing out of render() and
into more appropriate places without doing a lot of unnecessary
accounting. Miguel, do you have in mind another point, other than
rendering, where one would set this visibility flag?
I feel strongly that you should define the functionality that you want for
the 'visible' set and freeze it.
I certainly like this definition, that is, the way it is now. We could
see if Eric approves.
A part of me says, "If it ain't broke, don't fix it!"
But I can understand the programmer's objection to that.
Bob
--
Robert M. Hanson, [EMAIL PROTECTED], 507-646-3107
Professor of Chemistry, St. Olaf College
1520 St. Olaf Ave., Northfield, MN 55057
mailto:[EMAIL PROTECTED]
http://www.stolaf.edu/people/hansonr
"Imagination is more important than knowledge." - Albert Einstein
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers
