Th K�hne (eisvogel) submitted some 'diffs' to clean up the Jmol code.
Thank you very much for taking the time to do this.
I am looking at the diff entries ...
Index: src/org/jmol/adapter/smarter/CifReader.java
=================================================================== RCS
file: /cvsroot/jmol/Jmol/src/org/jmol/adapter/smarter/CifReader.java,v
retrieving revision 1.16
diff -u -r1.16 CifReader.java
--- src/org/jmol/adapter/smarter/CifReader.java 15 Jul 2004 09:10:40 -0000
\ 1.16
+++ src/org/jmol/adapter/smarter/CifReader.java 18 Sep 2004 08:25:23 -0000
@@ -655,7 +655,7 @@
*</p>
*/
- class RidiculousFileFormatTokenizer {
+ static class RidiculousFileFormatTokenizer {
String str;
int ich;
int cch;
You have turned the RidiculousFileFormatTokenizer class into a 'static
inner class' ...
Q: What is the motivation for turning this into a 'static inner class'?
Q: In this case, does it offer any advantages?
more questions later ...
Miguel
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Jmol-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jmol-developers