if you change the settings Window:Preferences, in the Java:Compiler pane, under the Unused Code section to warnings for all the cases, you'll see even a lot more...
Then if you turn on the warnings for Javadoc, it gets even worse.
I fixed some of those, but with those additional warnings, I am up to 393 warnings....
By the way, thanks for setting it up so that Eclipse can build it. I am a bit surprised that it requires those . files since I assumed that using the Run:External option to use Ant should work too? But then I am completely new at Eclipse, but it is pretty neat, so I switched (from BBEdit/ant).
Cheers,
René
On Nov 5, 2004, at 2:58 PM, Nicolas Vervelle wrote:
Hi,
I added .project and .classpath files so that Jmol can be built under Eclipse.
Eclipse gave me then a lot of warnings in the java files, mainly unused imports.
I removed the unused imports but I still have a few warnings :
WARNING:
com/obrador
JpegEncoder.java, line 875, The assignment to variable code has no effect.
I think this line should be removed.
WARNING:
org/jmol/viewer
FileManager.java, line 110, The assignment to variable fullPathName has no effect.
I think this line should be "this.fullPathName = fullPathName;"
WARNING:
org/openscience/jmol/app
PngEncoder.java, line 174, The assignment to variable image has no effect.
I think this line should be removed.
WARNING:
org/openscience/jmol/app
Jmol.java, lines 320, 327, 336, The static method >>>> from the type OptionBuilder should be accessed in a static way.
I think that, for example, the current code :
options.addOption(
OptionBuilder.withLongOpt("script").
withDescription("script to run").
withValueSeparator('=').
hasArg().
create("s")
should be replaced by:
OptionsBuilder.withLongOpt("script");
OptionsBuilder.withDescription("script to run");
OptionsBuilder.withValueSeparator('=');
OptionsBuilder.hasArg();
options.addOption(OptionBuilder.create("s")
What do you think ?
Nicolas
