At 23:32 25/03/2005, Miguel wrote:
> Hi Miguel, > > I think that that is a good idea. I was wondering whether it may make > sense to capture a 'log' of errors which at the end of parsing the file > is thrown as an exception and not throw an exception during parsing and > stop parsing at that point. The latter is of course only possible if > the exception that occurs is indeed such that one can recover from it.
I was thinking of having a set of 'warning' strings. The JmolAdapter would iterate through the set of strings, fetching them one by one.
This would address warning conditions, but not error conditions that would throw an exception.
You are suggesting that we do something similar for error conditions.
What do you think about having the JmolAdapter never throw an exception ... but always having it return with a status condition (OK, warnings, errors) with a set of strings as messages ... to be handled by the client.
I think this is important (and non-trivial) since Jmol will be increasingly used in many different ways (for example we us it as part of a workflow where many different molecules in a list can be viewed). In general we don't want it to stop when it encounters an error, nor simply to display a blank screen. IMO there should be a visual message that indicates that something went wrong and a way of accessing the list of errors.
I would regard undisplayable atoms as an error/exception. By all means display the good ones but have a visual marking that there were undisplayable atoms and a list of errors. Otherwise people assume that no errorReport => no Errors.
P.
Peter Murray-Rust Unilever Centre for Molecular Informatics Chemistry Department, Cambridge University Lensfield Road, CAMBRIDGE, CB2 1EW, UK Tel: +44-1223-763069 Fax: +44 1223 763076
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
