>
> Miguel,
>
> I've applied this patch to CVS, but I'm not sure wether this was a good
> idea:
>
> @@ -40,7 +41,7 @@
>    public JmolApplet() {
>      super("org.jmol.applet.Jmol",
>            "jmol75x29x8.gif",
> -          "Loading Jmol applet ...",
> +          GT._("Loading Jmol applet ..."),
>            3, preloadClasses);
>    }
>
> In JmolApplet.java....
>
> I'm not sure how preloading of classes works, so please tell me if I need
> to
> revert this patch...

I have not been paying attention to the internationalization discussions.

I assume that GT._ is going to return the localized string.

If so, then there is probably nothing wrong with the patch.

However, I do have a concern. The purpose of the preloader was to have
something very small that would load quickly. If this requires that the GT
class be called early on, then all the localization stuff would need to be
part of the initial class load.

Now that I think about it, I think that you should revert the patch.

Give me some more data and let me think about it.


Miguel



-------------------------------------------------------
SF.Net email is sponsored by: GoToMeeting - the easiest way to collaborate
online with coworkers and clients while avoiding the high cost of travel and
communications. There is no equipment to buy and you can meet as often as
you want. Try it free.http://ads.osdn.com/?ad_idt02&alloc_id135&op=click
_______________________________________________
Jmol-developers mailing list
Jmol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to