[sent it to Bob directly instead of Jmol-dev]
Hi again,
a few examples of formatting by Eclipse that I don't think is good:
>- final static float[] decimalScale =
>- {0.1f, 0.01f, 0.001f, 0.0001f, 0.00001f, 0.000001f, 0.0000001f,
>0.00000001f};
>+ final static float[] decimalScale = { 0.1f, 0.01f, 0.001f, 0.0001f,
>0.00001f,
>+ 0.000001f, 0.0000001f, 0.00000001f };
Before, the variable was on one line and the values on one line.
After, we have a line with the variable + a part of the value, and a line with
the rest of the value
>- value *= ((exponent < tensScale.length)
>- ? tensScale[exponent - 1]
>- : Math.pow(10, exponent));
>+ value *= ((exponent < tensScale.length) ? tensScale[exponent - 1]
>+ : Math.pow(10, exponent));
Before, we had a line with the condition, a line with the "true" expression, a
line with the "false" expression
After, we have a line with the conditon + the "true" expression, a line with
the "false "expression
> /*
>- System.out.println("-----------\nline:" + line);
>- for (int i = 0; i < tokenCount; ++i)
>- System.out.println("token[" + i + "]=" + tokens[i]);
>- */
>+ * System.out.println("-----------\nline:" + line); for (int i = 0; i <
>+ * tokenCount; ++i) System.out.println("token[" + i + "]=" + tokens[i]);
>+ */
Here, the comment has been completely screwed.
Before it was commented code, not it's a cluttered comment.
I don't check the rest of the commit ;)
Nico
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers
