Bob, I see that you recently checked in a change to Eval.java
It looks like you went through and added some statementLength checking to a number of commands. Your intentions were good. However, be advised that there is separate statement length checking that happens at script compile time. The table in Token.java contains flags that are used by the compiler that designate the minimum number of arguments that are required for specific commands. Therefore, these runtime errors of insufficient statement length will not be triggered because they will be caught at script compile time. If there were problems with some specific cases then we should fix on a case-by-case basis in either Compiler.java or Token.java. But, in general we should not be running these tests. If there is an inconsistency between the compiler and the runtime then that indicates a fundamental problem and we want it to fail catastrophically, not *gracefully* ... you should roll-back your change. Miguel ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
