Miguel wrote:

should be just SpartanSmolReader and maybe a bit with AtomSetCollection

very simple. While you are at it, we made some minor changes to
CifReader for Eric to correct for some oddnesses there. Maybe this
should be a "file input" patch.


Yes, I think that one "file input" patch would be good.

But, it is not clear to me whether you+Egon think that I should commit the
trunk CifReader or not ... see below.


There is also the CsfReader I would like
to see put up. You should see the commit logs there -- pretty simple.


I don't think that we should introduce a reader for a new file type as a
bug-fix patch.

oh, right. sorry.



I took a very close look at the CifReader, and I've suggested Egon go
back to the PDB "blank" chain designation instead of "0" there. But I
think I changed that only on Bob200603 because I wanted to talk with the
CIF people first.  There seems to be some discrepency regarding our
advise on that one.


Egon, please work with Bob and figure out how this should work.

Unless something relatively urgent comes up, I don't think that we should
be in any hurry to merge into branches/10_2 and make a 10.2.1 bug-fix
release.

My understanding is that we do this fairly often so that the sort of major changes that were just checked in don't complicate the little bug fix things.

What I was referring to re Egon is on the BOB200603 branch, not the main branch. The main branch has a few important CIF fixes to get merged. The Bob branch has some decisions Egon and I need to go over.

So I would still argue for a bug fix update to 10.2 sooner rather than later.



Miguel



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

--

Robert M. Hanson, [EMAIL PROTECTED], 507-646-3107
Professor of Chemistry, St. Olaf College
1520 St. Olaf Ave., Northfield, MN 55057
mailto:[EMAIL PROTECTED]
http://www.stolaf.edu/people/hansonr

"Imagination is more important than knowledge."  - Albert Einstein


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to