> Jmol devs... > > I apologize for "breaking the build" over the weekend by > checking stuff into the main trunk erroneously. Luckily > Miguel spotted the error and > asked me to revert the changes,
Actually, Bob spotted it and encouraged me to invesigate. > hopefully before anyone was inconvenienced > by this. I am truely sorry about t hat. Not to worry ... no harm done. > Miguel - I already *am* on this mailing list from > [EMAIL PROTECTED], and I had thought my Pfizer email > would be fixed by now, but alas no. > > So the work I was trying to do was... Rest assured that we are fully supportive of your efforts to integrate Jmol into PFAAT. [snip] > There is one feature we added that represents a more significant change > and this is the one I added that > "broke the build" or more property "broke the applet". We added a > SelectWithin dialog to help > visually construct a script statement for selecting atoms withing a > given range of some atomic feature, such > as other atoms, the protein backbone, etc. > > I added code to Eval.java etc. to allow for a command: > selectWithinDialog. This dialog was in the > package org.openscience.jmol.app. Ie...it is a feature that is intended > for the standalone application, but > not for the Applet. I belive this was one of the mistakes I made: > checking in these chagnes to Eval.java, > because it referred to code that is meant only for the standalone app. Correct. I suspect that there will be other application-specific dialogs that we will want to activate from scripts, so we need to come up with a generic mechanism that will allow us to do this. > The other mistake I made was I was checking things into the main trunk, > not into a branch created for > the purpose of exploring these features and how they should be merged > into Jmol. > > As for the selectWithinDialog command - what Miguel and I had talked > about was creating a more generic > command for launching dialogs created by end -user / programmers for use > with standalone Jmol. Something > maybe like... > > open dialog XXXX > > The idea is the standalone app would register a "handler" with the core > that listed what dialogs it could open > and have the core Eval stuff call on that handler when a script is > executed to open one of those dialogs. Correct ... something like that > So...if anyone has any ideas they think I should keep in mind while > building this, let me know. > > And Miguel - am I allowed to make my own branch or do I ask you or Egon > to create it for me? I created a branch for you when we last spoke in March. Sorry that I did not make that clear. > If I cannot do it would you please create a branch > for me to work in? I just created a new branch for you that is a snapshot of the current trunk: https://svn.sourceforge.net/svnroot/jmol/branches/pauldana200605 Miguel ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
