Hi Daniel
I agree with you on the general principle of using relative units
rather than fixed ones, but
1) it it throws an error in the browser's javascript console, it is a
bug
--really, what the browser tells us is that it is wrong syntax.
2) this css rule is for the applet envelope, so it's defining the
size
of the rectangle that will hold the applet (or its absence). Pixels
are
the only choice here, since the applet size is also defined in pixels
(sz[0], sz[1]).
Anyway, thanks to your reply I see I've put a typo; yes, it must be
sz[1] + "px;" +
not
sz[1] + ";px" +
I cannot fix this now since I cannot commit until I'm back at home
--in fact, I can't do that until Sunday night.
If you can revert my change in SVN, I'll take care of this later. Or
you can fix position of the semicolon.
Apologies if I was too hasty in commiting this change. I realized
later that the Thanksgiving holiday was likely keeping US people away
from the email lists and so no answers to my initial post.
El 24 Nov 2006 a las 2:47, Daniel Leidert escribió:
> Am Donnerstag, den 23.11.2006, 15:04 -0800 schrieb
> [EMAIL PROTECTED]:
> > Revision: 6313
> > http://svn.sourceforge.net/jmol/?rev=6313&view=rev
> > Author: aherraez
> > Date: 2006-11-23 15:04:43 -0800 (Thu, 23 Nov 2006)
> >
> > Log Message:
> > -----------
> > fix CSS syntax error line 644
> >
> > Modified Paths:
> > --------------
> > trunk/Jmol/appletweb/Jmol.js
> >
> > Modified: trunk/Jmol/appletweb/Jmol.js
> > ===================================================================
> > --- trunk/Jmol/appletweb/Jmol.js 2006-11-23 20:29:40 UTC (rev 6312)
> > +++ trunk/Jmol/appletweb/Jmol.js 2006-11-23 23:04:43 UTC (rev 6313)
> > @@ -641,7 +641,7 @@
> > if (isIEWin || useHtml4Object) {
> > visitJava =
> > "<p style='background-color:yellow;" +
> > - "width:" + sz[0] + ";height:" + sz[1] + ";" +
> > + "width:" + sz[0] + "px;height:" + sz[1] + ";px" +
> ^^^
> I guess, it should be "px;", right? But a missing scale unit is IMO not
> a bug and scale units can be "evil" sometimes (especially the px-unit -
> em should be preferred to result in "scalable" and not fixed output).
>
> Regards, Daniel
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers
