Jmol developers: I took the liberty today to do a major refactoring of org.jmol.modelframe.Frame. Here's the scoop:
For a LONG time it has bugged me that jmol "Frame" has nothing to do with "frames". In addition, in trying to figure out the bug that Freida pointed out relating to "load append" and groups, I had to understand everything that was in org.jmol.modelframe.Frame.java. I realized that there were really two classes embedded in one -- a model set "initializer" and a model set information "server". So I went through all the methods and made them as private as I could, then split the class into two classes: ModelSet ModelSetLoader extends ModelSet Mostly this is just aesthetic. ModelSetLoader is pretty much all private methods that are executed only when there is a zap, a model set is loaded, or one or more models is merged with the current model set. Except for one method (calculateStructures), all these methods are used only once, only when the file set is opened. ModelSet is all the rest -- mostly methods accessed by ModelManager. Lots and lots of short public, default, and protected methods here. This of course affected a lot of related files, so there was a series of commits there to do that. Then it seemed to me that to finish it off, I should change "org.jmol.modelframe" to "org.jmol.modelset". So there's a second flurry of commits that took care of that. In the process I found a bug lurking in the popup menu -- select...elements wasn't working when multiple models were displayed. That's working now. Eclipse is just amazing. I hope this doesn't cause anyone any grief. Bob ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
