This didn't seem to reach the list the first time, therefore I send it again:

---------- Forwarded message ----------
From: pim schravendijk <[EMAIL PROTECTED]>
Date: Jul 27, 2007 2:52 PM
Subject: Correction to Axes.java code...
To: [email protected]


"axes scale ..." did not work for the "axes unitcell" option. This is
a desired option, however, especially when using a lot of periodic
images of the lattice, where the axis system gets lost in the center,
but the axes should keep the vectors and base coordinates of the main
lattice.

My suggestion:

Index: src/org/jmol/shape/Axes.java
===================================================================
--- src/org/jmol/shape/Axes.java        (revision 8017)
+++ src/org/jmol/shape/Axes.java        (working copy)
@@ -64,6 +64,12 @@
       axisPoints[0].add(offset, vectors[4]);
       axisPoints[1].add(offset, vectors[2]);
       axisPoints[2].add(offset, vectors[1]);
+      // UnitCell should not use setScale as it has only 3 axisPoints
+      for (int i = 3; --i >= 0;) {
+        axisPoints[i].x *= viewer.getAxesScale()/2.0;
+        axisPoints[i].y *= viewer.getAxesScale()/2.0;
+        axisPoints[i].z *= viewer.getAxesScale()/2.0;
+      }
       return;
     } else if (axesMode == JmolConstants.AXES_MODE_MOLECULAR) {
       originPoint.set(0, 0, 0);

This is tested for tetragonal, orthorhombic and rhombohedral unit cells.

Now if I would like to put this back to the SVN system, can I use the
info written in
http://wiki.jmol.org/index.php/Release_Procedures#Release_build? Some
of the text there seems not to fit, e.g.:

What is the preferred text to use as the commit message?
the  page says: svn commit -m "prerelease 10.3.1", but I wouldn't know
on what prerelease I would be working.
Also the svn copy commands don't seem to apply to my case.

Any help is appreciated!

--
Greetings, Pim
http://www.molmod.com


-- 
Greetings, Pim
http://www.molmod.com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to