Patches item #1039144, was opened at 2004-10-03 05:01
Message generated for change (Comment added) made by wkpark
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379135&aid=1039144&group_id=23629

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Won Kyu Park (wkpark)
Assigned to: Nobody/Anonymous (nobody)
Summary: mouse shift-drag enhancement

Initial Comment:
mouse drag with a shiftkey enhancement

---------
Index:
src/org/openscience/jmol/viewer/managers/MouseManager.java
===================================================================
RCS file:
/cvsroot/jmol/Jmol/src/org/openscience/jmol/viewer/managers/MouseManager.java,v
retrieving revision 1.36
diff -u -r1.36 MouseManager.java
---
src/org/openscience/jmol/viewer/managers/MouseManager.java
19 Sep 2004 00:45:50 -0000      1.36
+++
src/org/openscience/jmol/viewer/managers/MouseManager.java
2 Oct 2004 19:53:07 -0000
@@ -298,6 +298,8 @@
       viewer.zoomBy(deltaY);
       // fall into
     case SHIFT_RIGHT: // the one-button Mac folks
won't get this gesture
+      if (yCurrent > viewer.getScreenHeight() / 2)
+        deltaX*=-1;
       viewer.rotateZBy(-deltaX);
       break;
     }
--------
mouse drag action to Zoom or Rotate is common action

people may drag down to zoom up and rotate it.
 * drag down: updown gesture
 * rotate: downside left right gesture
but, with left-right gesture it rotate counterclock wise.
clockwise is more intuitive action.

this patch fix like following:
upside gesture with viewer.rotateZBy(-deltaX)
downside gesiture with viewer.rotateZBy(deltaX)

----------------------------------------------------------------------

>Comment By: Won Kyu Park (wkpark)
Date: 2007-11-12 19:25

Message:
Logged In: YES 
user_id=76597
Originator: YES

It also related with PR #1830041 :)

----------------------------------------------------------------------

Comment By: Won Kyu Park (wkpark)
Date: 2004-10-03 06:47

Message:
Logged In: YES 
user_id=76597

you can test above simple patch at the following link:

http://chemie.skku.ac.kr/wiki/jmol.html

----------------------------------------------------------------------

Comment By: Won Kyu Park (wkpark)
Date: 2004-10-03 06:41

Message:
Logged In: YES 
user_id=76597

> It means that the meaning of the mouse gesture changes
> depending upon where the mouse is located.

Yes. but It is more confuse for people with *downside*
left-right or  right-left action. molecular expected to
rotate along the mouse cursor movement but now, molecular
rotate reversly

----------------------------------------------------------------------

Comment By: Miguel (migueljmol)
Date: 2004-10-03 05:34

Message:
Logged In: YES 
user_id=1050060

I am not convinced that this is a good change. 

It means that the meaning of the mouse gesture changes depending upon 
where the mouse is located. 

I suggest that you post a message to the jmol-users mailing list and ask 
people what they think. 


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379135&aid=1039144&group_id=23629

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Jmol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to