Patches item #3527769, was opened at 2012-05-17 21:05 Message generated for change (Comment added) made by hansonr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=379135&aid=3527769&group_id=23629
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: User Interface Group: None Status: Open Priority: 5 Private: No Submitted By: Gong Zhang (g0516) Assigned to: Bob Hanson (hansonr) Summary: Add a button in 'About Jmol ' pop dialog patch Initial Comment: The patch is about adding a 'Back to About' button at the bottom of pop dialog 'About Jmol'. After a user clicks one link in the 'About Jmol' pop dialog which includes some web links to view that link's content, the user can click the 'Back to About' button to return to the origin dialog which includes several links if that user wants to view the content of another link. ---------------------------------------------------------------------- >Comment By: Bob Hanson (hansonr) Date: 2012-05-19 08:01 Message: That worked this time. Actually, though, I thought of a better idea. It makes little sense to build our own browser for external links. Take a look at what I just checked in. ---------------------------------------------------------------------- Comment By: Gong Zhang (g0516) Date: 2012-05-19 01:58 Message: Sorry, I work on the Jmol [trunk/Jmol] of the 'https://jmol.svn.sourceforge.net/svnroot/jmol'. I checked out the source code again today, made sure that the revision is 17159 and version is 12.3.26. Then I put the modified code in the 'Jmol\src\org\openscience\jmol\app\jmolpanel\AboutDialog.java' and created a patch named 'aboutDialog.patch'. It has been patched in this page. I wish it can work. Tnanks ---------------------------------------------------------------------- Comment By: Bob Hanson (hansonr) Date: 2012-05-18 21:06 Message: Yes, but was it the trunk or the branch? What version of Jmol did you apply it to? ---------------------------------------------------------------------- Comment By: Gong Zhang (g0516) Date: 2012-05-18 20:25 Message: I got the source code by SVN command in the sourceforge website. This patch is just to add a new button at the bottom of the 'About Jmol' pop window to perform a 'back to' function. ---------------------------------------------------------------------- Comment By: Bob Hanson (hansonr) Date: 2012-05-18 15:00 Message: I don't see exactly what the problem is, but Eclipse isn't letting me apply that. Are you sure you did that work on the root, Jmol 12.3.16_dev? We don't apply patches to released versions such as 12.2. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=379135&aid=3527769&group_id=23629 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
