Bugs item #3556998, was opened at 2012-08-13 11:38
Message generated for change (Comment added) made by hansonr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=3556998&group_id=23629

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Website
Group: v12
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Angel Herraez (aherraez)
Assigned to: Bob Hanson (hansonr)
Summary: disabled java warning is not displayed (JSO)

Initial Comment:
Using the JSO methods in a setup similar to 
http://biomodel.uah.es/Jmol/JSO/simpleJmol4.htm, with unsigned applet,  no 
jQuery , no ChemDoodle etc. options active.
(Jmol 13.0.RC5, Firefox 13 Win)

 I see the applet normally. If I disable Java, instead of the warning in yellow 
square, a blank square is displayed. 
It seems that the browser is getting a non-specified image substitute. This is 
the relevant generated source:

<div id="myJmol_appletdiv" style="width:100%;height:100%">
<img id="myJmol_image" src="" height="300" width="300">
</div>

If the (server-side?) image generation is not available for whatever reason, 
the old "please install or enable Java" note should be displayed --it is indeed 
implemented in JmolApplet.js 



----------------------------------------------------------------------

>Comment By: Bob Hanson (hansonr)
Date: 2012-08-14 13:10

Message:
I think there are a couple of problems:

1) navigator.javaEnabled() does not work with MSIE (it reports TRUE
always). So the switch to images does not work. 

2) the logic does not allow you to force the issue and avoid the image
option.

So what  is happening is that Firefox is (correctly) going to the image
option but not providing an out for that, and MSIE is (incorrectly) NOT
going to the image option.

The real solution is to dump all this logic business. Too crazy. 

OK, first, let's get rid of this logic maze. 

Info.use = "JAVA WEBGL HTML5 IMAGE"

meaning check those in that order. 

Now, as for MSIE, we are just not going to be able to support MSIE browsers
where the user has explicitly disabled Java. Those users will get the NO
JAVA message. 

The  problem with Firefox is fixed, though. That was a simple logic
problem. I'm setting the default to be 

Info.use = "JAVA"

I've checked in new JmolCore.js and JmolApi.js for that. 


----------------------------------------------------------------------

Comment By: Angel Herraez (aherraez)
Date: 2012-08-14 09:42

Message:
I think I've got it.
The applet code (including the fallback warning) was not being called
because of a filter for disabled java.

I've done a change in JmolApi.js that fixes it (attached, see line 56).
The idea is
- if useImageOnly is imposed, avoid the applet and the warning
- if NoApplet is imposed, avoid the the applet and the warning
- if useJmolOnly is imposed, you want to advise the user, so display the
warning by letting the applet code to be inserted
- if use of Jmol is optional, allow the applet as long as the browser+java
are ok, otherwise let it fall back to other options like the image

A sample (without the fix) is the applet at top-right of
http://http://biomodel.uah.es/Jmol/JSO/simpleJmol3-0.htm

(the other two applets in that page suffer of different problems which I'm
working on)
Sorry, I have limited internet access and so cannot provide a more focused
example now, but that shows it.




----------------------------------------------------------------------

Comment By: Bob Hanson (hansonr)
Date: 2012-08-14 09:14

Message:
Can we have a link to the offending page? I don't see how it can be calling
the image option just because there is no Java enabled.



----------------------------------------------------------------------

Comment By: Angel Herraez (aherraez)
Date: 2012-08-14 03:30

Message:
Well, I updated JmoApplet.js. No difference yet.
I was not using "useJmolOnly: true", but isn't that default? I added it, no
change.
Also tried adding "useImageOnly: false" --also default--: no change.

Must be some of the other options, since I'm pursuing a simplest aplet
setup, Jmol, no alternative formats.

Also it might be the way I'm disabling Java (via the "Plugins Toggler"
extension of Firefox) but for pages that use Jmol.js it works fine and I
get the yellow square.


----------------------------------------------------------------------

Comment By: Bob Hanson (hansonr)
Date: 2012-08-13 16:20

Message:
well, actually there was a different bug. See the new JmolApplet.js

----------------------------------------------------------------------

Comment By: Bob Hanson (hansonr)
Date: 2012-08-13 16:00

Message:
Are you sure you have the Info parameter "useJmolOnly" set to true? Looks
to me like it is switching to image mode, which is the correct action.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379133&aid=3556998&group_id=23629

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Jmol-developers mailing list
Jmol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to