Angel Herraez wrote: >Hello to all, and wishing you that 2007 is even more satisfying than the >former years! > >I am completing some missing bits of documentation in Jmol.js Javascript >Library webpage (http://jmol.sourceforge.net/jslibrary/) and have a couple of >questions --mainly for Bob, I guess-- > >1) >jmolRadioGroup() is not passing the 'title' argument to _jmolRadio() > >It is claimed to do so, and others like jmolRadio() do; I think it needs a fix >in >line 204 of Jmol.js > > > > ok, I've fixed that.
>2) >jmolScriptWait() has > if(!targetSuffix)targetSuffix="0" >to provide for a default applet to apply to. >Shouldn't jmolScriptWaitAsArray() have it too? (a fix in line 1076 of Jmol.js) > > > At one point I was worried that "undefined" would mess up the passing on of the targetSuffix parameter if that was missing. I can't remember if this was warranted in some odd browser or not, but as a result I started adding if(!targetSuffix)targetSuffix="0" to the beginning of my newer scripts. I think this is unnecessary -- jmolScript(), for example, doesn't include it -- so my guess is that all these could be removed. Let's just leave them in for now, as it makes the code a bit more understandable. >3) >Apart from Jmol.js: >I've noticed that if a "load" command fails, this is shown in the applet, and >catched by jmolScriptWait from the status messages: > ERROR: Jmol script terminated unsuccesscully >There is a "c" there that should be an "f". The "successful" version is OK. > > > Nico has fixed this, I see. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Jmol-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-users
