The following fix was sent to me and I am posting it to the list server for others to see.
Along with the fix below I also tried: Replace: $this->mJmolTagPresent = false; in function onParserBeforeStrip With: return $this->mJmolTagPresent = false; And Replace: $this->mJmolTagPresent = false; in function onParserAfterStrip With: return $this->mJmolTagPresent = false; These replacements work on my system. Paul Shiller Tribological Specialist Ph:+1-330-471-3344 EMail: [EMAIL PROTECTED] -----Original Message----- From: Nicolas Vervelle [mailto:[EMAIL PROTECTED] Sent: Wednesday, September 26, 2007 3:18 PM To: [email protected] Cc: Shiller, Paul J. Subject: Re: [Jmol-users] Internal error - embedding Jmol in MediaWiki Hi, My mail probably won't reach the mailing list (problems with my ISP), can you forward it to the jmol-users mailing list so that other users can participate ? I haven't worked for a long time on the extension mostly due to a lack of time. I know people are interested in getting it on Wikipedia (sorry for having not worked on it recently), so if someone is interested in continuing development (especially the security part), he would be very welcome :) Concerning your problem, it seems that recent versions of Mediawiki are more strict on the hooks. I think the fix is quite simple. Can you try it ? Simply add "return true;" at the end of both onParserBeforeStrip and onParserAfterStrip ? Mediawiki should be happy with this fix. Keep us posted with the results. Nico Shiller, Paul J. a écrit : > I have been trying to get Jmol to work on a MediaWiki project I am > starting. I have followed the installation instructions including > creating the JmolExtension.php file. On the first attempt the Wiki was > "Unable to display the [main] Page". Removing the "require_once" > instruction in the LocalSettings.php file allowed me to start the Wiki. > Starting the Wiki and changing the LocalSettings (activating the > "require_once" instruction)led to the following debug information: > > Internal error > > Detected bug in an extension! Hook JmolExtension::onParserBeforeStrip > failed to return a value; should return true to continue hook processing > or false to abort. > > Backtrace: > > #0 E:\PortableApps\xampp\htdocs\wi\includes\Parser.php(303): > wfRunHooks() > #1 E:\PortableApps\xampp\htdocs\wi\includes\Article.php(3017): > Parser->parse('ParserBeforeStr...', Array) > #2 E:\PortableApps\xampp\htdocs\wi\includes\Article.php(831): > Article->outputWikiText('<big>'''Welcome...', Object(Title), > Object(ParserOptions), true, true, 87) > #3 E:\PortableApps\xampp\htdocs\wi\includes\Wiki.php(383): > Article->view('<big>'''Welcome...') > #4 E:\PortableApps\xampp\htdocs\wi\includes\Wiki.php(48): > MediaWiki->performAction() > #5 E:\PortableApps\xampp\htdocs\wi\index.php(89): > MediaWiki->initialize(Object(OutputPage), Object(Article), > Object(Title), Object(User), Object(WebRequest)) > #6 {main} > > Are there any suggestions on how to fix this? As you can tell from the > above test I am running this under the Portable Apps, xampp installation > on a Windows XP system. > > Paul Shiller > ----------------------------------------- This message and any attachments are intended for the individual or entity named above. If you are not the intended recipient, please do not forward, copy, print, use or disclose this communication to others; also please notify the sender by replying to this message, and then delete it from your system. The Timken Company / The Timken Corporation ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Jmol-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-users
