Bob,

I found it!

The problem was in my callback function. This might be the oldest code in my page!

scpt = "select atomIndex = _atomPicked;color " + atomColor + ";select;";
        jmolScript(scpt);

Although it's cast in newer _atomPicked and jmolScript syntax, that final select has been around a long time. That's what broke it. Changing it to select * solved the problem.

I think I have other cases of using select to mean select all. I'd better check.

Otis

Otis Rothenberger
chemagic.com


On 11/6/2010 7:38 PM, Otis Rothenberger wrote:
Bob,

I can bring up the Jmol menu now, but an atom click after the picking changes still locks the applet. Same behavior there.

Otis
Otis Rothenberger
chemagic.com

On 11/6/2010 3:16 PM, Robert Hanson wrote:
Otis, please try 12.1.18.

On Sat, Nov 6, 2010 at 1:44 PM, Robert Hanson <[email protected] <mailto:[email protected]>> wrote:

    forget 12.1.17....

    On Sat, Nov 6, 2010 at 1:08 PM, Otis Rothenberger
    <[email protected] <mailto:[email protected]>> wrote:

        Bob,

        I encountered two problems with this. I don't know if they
        are related;

        1) On the initial load, I cannot bring up the Jmol menu.
        2) I open in model kit mode, and that seems to work ok. But
        when I change picking modes to allow atom picking color
        changes via a callback, the applet locks up after I click an
        atom for a color change. The atom does not change color, but
        interestingly, if I move to another browser tab and then come
        back, the color is changed, but the applet is still locked.

        Here is the message call back information via JavaScript just
        before the lock:

        script 9 started~set picking off;~set picking on;~set
        bondpicking false;~bondPicking = false~axes off;~hover
        off;~echo;~~Script completed~script 10 started~select
        atomIndex = _atomPicked;~1 atoms selected~color cpk;~select;~

        Here is the JavaScript that sets up the color picking. I
        think only the jmolScript() is relevant to the problem:

            if (x == 2) { jmolScript("set picking off;set picking
        on;set bondpicking false;axes off;hover off; echo;");
        picsOff(); colorPicOn = true; }

        At this point, I can still rotate, and if I back off (back to
        model kit mode) before clicking an atom, I'm OK. Here's the
        back off JavaScript:

            if (x == 1) { jmolScript("set picking off;set picking
        on;set bondpicking true;axes off;hover off; echo;");
        picsOff(); jmkLnksOff("x"); setKitDefault(); }

        In the above code snips, the only relevant non-Jmol script
        function is setKitDefault()

        function setKitDefault() {
            jmkLnksOff("x"); jmkLnksOff("y"); jmolScript("set picking
        assignAtom_C;set picking assignBond_p;");
        }

        What do you think? Problem on my end, Jmol bug, corrupt applet?

        Otis

        PS
        I cleared cache, update Java, and rebooted.


        Otis Rothenberger
        chemagic.com  <http://chemagic.com/>


        On 11/6/2010 11:24 AM, Robert Hanson wrote:
        version=12.1.17 now at
        https://sourceforge.net/projects/jmol/files/

        new features:
          load OFFSET
          reset STRUCTURE
          isosurface ROTATE <quaternion>
          auxiliaryInfo.models[1].infoUnitCell
          VASP OUTCAR reader

        various bug fixes:
          file loading
          atom picking
          miscellaneous
        ------------------------------

        new feature: load OFFSET {x y z}
           --follows UNITCELL parameter, if present
           --offsets the atoms in the file by a given amount
           --may be fractional
           --added to allow for shifts in origin for nonstandard CIF
        files
           --applicable to ALL readers
           --for example:
                load quartz.cif {1 1 1} spacegroup "ignoreoperators"
        offset{0 0 2/3}
                load caffeine.xyz offset {8.0 0 0}

        new feature: reset STRUCTURE -- resets structure to author's
        (in PDB or mmCIF file) after calculate STRUCTURE

        new feature: isosurface ROTATE <quaternion>
           -- rotates an isosurface based on a quaternion
           -- a display property, like OFFSET or SCALE3D
           -- useful if model coordinates are changed and an
        isosurface is present
           -- rotations are cumulative.
           -- rotations are about {0 0 0}, not the centroid of the
        isosurface
           -- ROTATE NONE removes the rotation
           -- for example:

                 isosurface sasurface ROTATE @{quaternion({1 0 0}, 90)}
                 isosurface ROTATE @{quaternion({1 0 0}, 90)} ROTATE
        @{quaternion({0 0 1}, 90)}

        new feature: auxiliaryInfo.models[1].infoUnitCell
           -- 17-element array
           -- a, b, c, alpha, beta, gamma
           -- Va, Vb, Vc
           -- dimension = 1 (polymer), 2 (slab), 3 (standard)
           -- volume (Angstrom^3)

        new feature: VASP OUTCAR reader (xtal/VaspReader)

        -----------------------

        file loading:

        bug fix: load PACKED for slab/polymer does not work
        bug fix: load "" does not work after loading a SET of models
        using load DATA
        bug fix: load xxx where x is a flawed data file can try to
        load file as a script or isosurface
        bug fix: PDB reader not reading files with empty group name
        field
        bug fix: CIF reader cannot read files with
        _space_group_symop_operation_xyz field
        bug fix: LINUX file dropper returning \r\n with name
        bug fix: Argus .agl reader not setting viewpoint transform
        bug fix: no loadStructCallback reported for ZAP {atomExpression}

        atom picking:

        bug fix: set picking invert stereo/delete atom  not sending
        pick callback
        bug fix: set picking chain, then mouse click does not report
        number of atoms selected
        bug fix: (application only) distance picking not being
        reported in console
        bug fix: (application only) set picking measure SEQUENCE not
        reported in console

        misc:

        bug fix: DRAW PERP $xxx reverses order of points
        bug fix: compare(...) with @SP, @OH, @TB gives null pointer
        exception
        bug fix: popup menu does not include measure SEQUENCE
        bug fix: compiler function(){{ double brace error
        bug fix: compiler context { var chain=3;print chain } not
        recognizing context variable for "chain"


-- Robert M. Hanson
        Professor of Chemistry
        St. Olaf College
        1520 St. Olaf Ave.
        Northfield, MN 55057
        http://www.stolaf.edu/people/hansonr
        phone: 507-786-3107


        If nature does not answer first what we want,
        it is better to take what answer we get.

        -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900


        
------------------------------------------------------------------------------
        The Next 800 Companies to Lead America's Growth: New Video Whitepaper
        David G. Thomson, author of the best-selling book "Blueprint to a
        Billion" shares his insights and actions to help propel your
        business during the next growth cycle. Listen Now!
        http://p.sf.net/sfu/SAP-dev2dev


        _______________________________________________
        Jmol-users mailing list
        [email protected]  
<mailto:[email protected]>
        https://lists.sourceforge.net/lists/listinfo/jmol-users

        
------------------------------------------------------------------------------
        The Next 800 Companies to Lead America's Growth: New Video
        Whitepaper
        David G. Thomson, author of the best-selling book "Blueprint to a
        Billion" shares his insights and actions to help propel your
        business during the next growth cycle. Listen Now!
        http://p.sf.net/sfu/SAP-dev2dev
        _______________________________________________
        Jmol-users mailing list
        [email protected]
        <mailto:[email protected]>
        https://lists.sourceforge.net/lists/listinfo/jmol-users




-- Robert M. Hanson
    Professor of Chemistry
    St. Olaf College
    1520 St. Olaf Ave.
    Northfield, MN 55057
    http://www.stolaf.edu/people/hansonr
    phone: 507-786-3107


    If nature does not answer first what we want,
    it is better to take what answer we get.

    -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900




--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
1520 St. Olaf Ave.
Northfield, MN 55057
http://www.stolaf.edu/people/hansonr
phone: 507-786-3107


If nature does not answer first what we want,
it is better to take what answer we get.

-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900


------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev


_______________________________________________
Jmol-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-users


------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev


_______________________________________________
Jmol-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-users
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Jmol-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jmol-users

Reply via email to