|
Rob, You write:
In the change sets some variable postfixes were renamed Nbr -> No Example: Long seqNbr = getNotificationSequenceNumber(); + Long seqNo = atomicSeqNo.incrementAndGet();The abbreviation No could also could mean: No as in 'Yes'/'No' , No as in 'Notation', besides 'Number'. Generally avoiding unclear naming seems desirable. Comments ? First of all, I'm very happy to see someone paying this much
attention to my changes! You are probably right: I think seqNum is a better abbreviation than
seqNo. On the other hand, seqNo is the abbreviation used in the few
other places in the JMX source where there is a local variable or
parameter that is a sequence number. Google shows 313,000 hits for
"seqnum" and 5,480,000 for "seqno" so we might
conclude that both are fairly standard abbreviations with "seqno" being
commoner. "seqnbr" comes in a poor third at 10,100 so I think I was
justified in renaming it in any case. (Google Code Search shows about
equal numbers for seqno and seqnum.) We could do a sweep over the JMX sources to rename the various seqNo
(and paramNo) variables to seqNum (paramNum). But there's a tension
here between slightly improved readability and the noise that would be
generated by such a change. However, I'll bear your suggestion in mind
for future changes, and this is also a reminder for me that I should
have sent the diffs to the public [email protected] list for
review. -- Éamonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ |
