Jaroslav,

The fix is OK for me.
The class MBeanInfo could be simplified because the constructors ensure that attributes, constructors, operations and notifications are not null, then we can remove all those nonNullxxx methods.

Shanliang

Jaroslav Bachorik wrote:
Please, review the fix for JDK-8002307.

The fix assures the immutability by cloning the provided arrays in the
constructor and then cloning them again in the getters.

The constructors are fixed in the javax/management/MBeanInfo.java and
the arrays used in getters are cloned using an already existing
functionality in the same class.

http://cr.openjdk.java.net/~jbachorik/8002307/webrev.01

Thanks,

-JB-

Reply via email to