On 09/03/2013 01:26 PM, Jaroslav Bachorik wrote: > On 09/03/2013 12:57 PM, Alan Bateman wrote: >> On 03/09/2013 09:02, Jaroslav Bachorik wrote: >>> Please, review the following patch: >>> http://cr.openjdk.java.net/~jbachorik/8004179/webrev.01 >>> >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8004179 >>> >>> It addresses the problem of the test not properly cleaning up the >>> created threads at exit. It does so by running the test in "othervm" >>> mode. Although it is possible to modify the test to cleanup the threads >>> at exit it would add more complexity to the test while achieving the >>> same result as running the test in "othervm" mode. >>> >>> Thanks, >>> >>> -JB - >> This looks okay. There is a second test that I noted in the bug that has >> a similar issue, maybe that needs its own bug. > > Hm, actually there are 6 other tests using the LockingThread class which > leaves the threads running. So all those tests should be made running in > "othervm" mode.
I was too hasty, it seems. The number of tests not being run in "othervm" mode and leaving live threads is 4 (in addition to SynchronizerLockingThread). They are: java/lang/management/ThreadMXBean/MyOwnSynchronizer java/lang/management/ThreadMXBean/SharedSynchronizer java/lang/management/ThreadMXBean/SynchronizationStatistics java/lang/management/ThreadMXBean/LockedMonitors -JB- > > Does increasing the number of tests running in "othervm" mode have any > negative consequences? > > -JB- > >> >> -Alan >
