On Fri, 17 Jan 2025 19:14:13 GMT, Kevin Walls <[email protected]> wrote:
>> This is a post-SecurityManager-removal cleanup, following-on from:
>>
>> 8344394: Remove SecurityManager and related calls from java.management.rmi
>>
>>
>> Remove mention of "privilege" in Exception handling in RMIConnectionImpl.
>> Remove wrapping of Exceptions in PrivilegedActionException.
>>
>> The methods that invoke an operation handle expected Exceptions, but also
>> need to handle SecurityException and RuntimeException, to avoid their
>> default case of wrapping an Exception in an IOException to signal a problem.
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Remove unnecessary/dup catches
> - Merge remote-tracking branch 'upstream/master' into
> 8345079_RMIConnectionImpl_excep
> - unnecessary catches
> - (c)
> - 8345079: Simplify/cleanup Exception handling in RMIConnectionImpl
src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
line 1008:
> 1006: throw (RuntimeException) e;
> 1007: } else if (e instanceof RuntimeException) {
> 1008: throw (RuntimeException) e;
duplicated? see lines 1005-1006
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23072#discussion_r1922778848
