On Mon, 27 Jan 2025 21:12:34 GMT, Chris Plummer <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove noSuchMethod method
>> - Remove removal warnings suppression
>
> src/java.management/share/classes/com/sun/jmx/mbeanserver/PerInterface.java
> line 111:
>
>> 109: if (list == null) {
>> 110: final String msg = "No such operation: " + operation;
>> 111: throw new ReflectionException(new
>> NoSuchMethodException(operation + sigString(signature)), msg);
>
> I think this is much better, but I still think it's odd that `operation` is
> in both exceptions (after your changes it's a lot more clear that this is the
> case), but I'm okay with that for the sake of not risking any compatibility
> issues.
Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23132#discussion_r1931797096
