On Sun, 26 Oct 2025 15:10:36 GMT, Jonas Norlinder <[email protected]> wrote:
> The end-goal of this test was to verify that the implementation correctly > guarded against races during shutdown which it manged to test. So to that end > I'm not sure this particular test needs re-work as it correctly manages to > run Java code that races on this method during VM shutdown. However, if I > understand your comment you are suggesting that we should (1) simplify how > the test is invoked (2) add a test for checking that the value is > monotonically increasing. For the latter I did not add such test as we in the > end rely on`os::thread_cpu_time`. It would be good to create unit test for the API/feature. Future maintainers will thank you. The test in the PR is focused on the shutdown scenario and be renamed to reflect that. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27537#discussion_r2463885768
