On Fri, 31 Oct 2025 13:06:48 GMT, Matthew Donovan <[email protected]> wrote:
>> test/jdk/javax/net/ssl/HttpsURLConnection/CriticalSubjectAltName.java line
>> 221:
>>
>>> 219: if (args[1].contains("MD5")) {
>>> 220: // MD5 is used in this test case, don't disable MD5
>>> algorithm.
>>> 221:
>>> SecurityUtils.removeFromDisabledAlgs("jdk.certpath.disabledAlgorithms",
>>
>> Line length > 80. Also, I think `If MD5 is used ..` comment would be better
>> because we don't always use MD5. Here and in other tests.
>
> I removed the comment entirely. It seemed redundant to say "if MD5 is used"
> right below the `if(args[0].equals("MD5")`
Yes, makes sense. Please also fix the line length.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27342#discussion_r2481598670
