Revision: 5629
http://jnode.svn.sourceforge.net/jnode/?rev=5629&view=rev
Author: crawley
Date: 2009-08-02 05:57:35 +0000 (Sun, 02 Aug 2009)
Log Message:
-----------
Use StringBuilder instead of StringBuffer where possible.
Modified Paths:
--------------
trunk/shell/src/shell/org/jnode/shell/PathnamePattern.java
trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneContext.java
trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneTokenizer.java
trunk/shell/src/shell/org/jnode/shell/bjorne/CaseCommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/CaseItemNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/CommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/ForCommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/FunctionDefinitionNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/IfCommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/ListCommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/LoopCommandNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/RedirectionNode.java
trunk/shell/src/shell/org/jnode/shell/bjorne/SimpleCommandNode.java
trunk/shell/src/shell/org/jnode/shell/help/def/DefaultHelpFactory.java
trunk/shell/src/shell/org/jnode/shell/help/def/NewSyntaxHelp.java
trunk/shell/src/shell/org/jnode/shell/syntax/MuParser.java
Modified: trunk/shell/src/shell/org/jnode/shell/PathnamePattern.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/PathnamePattern.java 2009-08-02
05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/PathnamePattern.java 2009-08-02
05:57:35 UTC (rev 5629)
@@ -419,7 +419,7 @@
// in the source pattern being accidentally mapped to Java regex
// meta-characters.
int len = pattern.length();
- StringBuffer sb = new StringBuffer(len);
+ StringBuilder sb = new StringBuilder(len);
char quote = (pp == null) ? ((char) 0) : pp.lastQuote;
boolean eager = (flags & EAGER) != 0;
for (int i = 0; i < len; i++) {
@@ -446,7 +446,7 @@
case '[':
if ((flags & CHARACTER_CLASSES) != 0) {
int j;
- StringBuffer sb2 = new StringBuffer(len);
+ StringBuilder sb2 = new StringBuilder(len);
boolean charClassOK = true;
LOOP:
for (j = i + 1; j < len; j++) {
@@ -564,7 +564,7 @@
}
public String toRegexString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("PathnamePattern{source='").append(this.source);
sb.append("',absolute=").append(this.isAbsolute);
sb.append(",patterns=[");
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneContext.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneContext.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneContext.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -451,9 +451,9 @@
* @param text the text to be processed.
* @return the de-quoted text
*/
- static StringBuffer dequote(String text) {
+ static StringBuilder dequote(String text) {
int len = text.length();
- StringBuffer sb = new StringBuffer(len);
+ StringBuilder sb = new StringBuilder(len);
int quote = 0;
for (int i = 0; i < len; i++) {
char ch = text.charAt(i);
@@ -572,7 +572,7 @@
void splitAndAppend(BjorneToken token, List<BjorneToken> wordTokens)
throws ShellException {
String text = token.getText();
- StringBuffer sb = null;
+ StringBuilder sb = null;
int len = text.length();
int quote = 0;
for (int i = 0; i < len; i++) {
@@ -625,9 +625,9 @@
return output;
}
- private StringBuffer accumulate(StringBuffer sb, char ch) {
+ private StringBuilder accumulate(StringBuilder sb, char ch) {
if (sb == null) {
- sb = new StringBuffer();
+ sb = new StringBuilder();
}
sb.append(ch);
return sb;
@@ -643,7 +643,7 @@
*/
public CharSequence dollarBacktickExpand(CharSequence text) throws
ShellException {
CharIterator ci = new CharIterator(text);
- StringBuffer sb = new StringBuffer(text.length());
+ StringBuilder sb = new StringBuilder(text.length());
char quote = 0;
int backtickStart = -1;
int ch = ci.nextCh();
@@ -719,7 +719,7 @@
case '-':
return specialVariable(ch, quote == '"');
default:
- StringBuffer sb = new StringBuffer().append((char) ch);
+ StringBuilder sb = new StringBuilder().append((char) ch);
ch = ci.peekCh();
while ((ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z') ||
(ch >= '0' && ch <= '9') || ch == '_') {
sb.append((char) ch);
@@ -732,7 +732,7 @@
private String dollarBraceExpansion(CharIterator ci) throws ShellException
{
// Scan to the '}' that matches the '${'
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
int braceLevel = 1;
int ch = ci.nextCh();
int quote = 0;
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneTokenizer.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneTokenizer.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/BjorneTokenizer.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -296,7 +296,7 @@
private BjorneToken parseWord() {
int quoteChar = 0;
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
int ch = peekCh();
int start = getPos() - 1;
LOOP:
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/CaseCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/CaseCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/CaseCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -47,7 +47,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("CaseCommand{").append(super.toString());
sb.append(",word=").append(word);
if (caseItems != null) {
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/CaseItemNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/CaseItemNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/CaseItemNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -39,7 +39,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("CaseItem{");
if (pattern != null) {
sb.append("pattern=");
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/CommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/CommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/CommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -114,7 +114,7 @@
throws ShellException;
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("nodeType=").append(nodeType);
if (flags != 0) {
sb.append(",flags=0x").append(Integer.toHexString(flags));
@@ -132,7 +132,7 @@
* @param sb the destination for rendering
* @param array the object array to be rendered.
*/
- protected static void appendArray(StringBuffer sb, Object[] array) {
+ protected static void appendArray(StringBuilder sb, Object[] array) {
sb.append('[');
for (int i = 0; i < array.length; i++) {
if (i > 0) {
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/ForCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/ForCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/ForCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -78,7 +78,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("LoopCommand{").append(super.toString());
sb.append(",var=").append(var);
if (words != null) {
Modified:
trunk/shell/src/shell/org/jnode/shell/bjorne/FunctionDefinitionNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/FunctionDefinitionNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/FunctionDefinitionNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -46,7 +46,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("FunctionDefinition{").append(super.toString());
sb.append(",name=").append(name);
sb.append(",body=").append(body);
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/IfCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/IfCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/IfCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -85,7 +85,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("IfCommand{").append(super.toString());
sb.append(",cond=").append(cond);
if (thenPart != null) {
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/ListCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/ListCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/ListCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -46,7 +46,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("ListCommand{").append(super.toString());
sb.append(",commands=");
appendArray(sb, commands);
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/LoopCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/LoopCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/LoopCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -65,7 +65,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("LoopCommand{").append(super.toString());
sb.append(",cond=").append(cond);
sb.append(",body=").append(body);
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/RedirectionNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/RedirectionNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/RedirectionNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -61,7 +61,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("Redirect{");
sb.append("redirectionType=").append(redirectionType);
if (io != null) {
Modified: trunk/shell/src/shell/org/jnode/shell/bjorne/SimpleCommandNode.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/bjorne/SimpleCommandNode.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/bjorne/SimpleCommandNode.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -63,7 +63,7 @@
}
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("SimpleCommand{").append(super.toString());
if (assignments != null) {
sb.append(",assignments=");
Modified: trunk/shell/src/shell/org/jnode/shell/help/def/DefaultHelpFactory.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/help/def/DefaultHelpFactory.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/help/def/DefaultHelpFactory.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -183,7 +183,7 @@
@Override
public void describeOption(FlagArgument arg, TreeSet<String> flagTokens,
PrintWriter out) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (String flagToken : flagTokens) {
if (sb.length() > 0) {
sb.append(" | ");
Modified: trunk/shell/src/shell/org/jnode/shell/help/def/NewSyntaxHelp.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/help/def/NewSyntaxHelp.java
2009-08-02 05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/help/def/NewSyntaxHelp.java
2009-08-02 05:57:35 UTC (rev 5629)
@@ -140,7 +140,7 @@
}
public void describeOption(FlagArgument arg, TreeSet<String> flagTokens,
PrintWriter out) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (String flagToken : flagTokens) {
if (sb.length() > 0) {
sb.append(" | ");
Modified: trunk/shell/src/shell/org/jnode/shell/syntax/MuParser.java
===================================================================
--- trunk/shell/src/shell/org/jnode/shell/syntax/MuParser.java 2009-08-02
05:50:17 UTC (rev 5628)
+++ trunk/shell/src/shell/org/jnode/shell/syntax/MuParser.java 2009-08-02
05:57:35 UTC (rev 5629)
@@ -371,7 +371,7 @@
private static String showStack(Deque<MuSyntax> stack, boolean oneLine) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (MuSyntax syntax : stack) {
if (sb.length() > 0) {
sb.append(", ");
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Jnode-svn-commits mailing list
Jnode-svn-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jnode-svn-commits
