The GitHub Actions job "Tests (AMD)" on 
airflow.git/scope-amazon-secrets-lookups-to-their-team has failed.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
b30d0303c45a78d2d660587c9a73c69f1b41de9a / Jarek Potiuk <[email protected]>
Apply the ambiguous-id refusal to get_config as well

The check used to live in _get_secret, which all three getters share. Moving it
up into get_conn_value and get_variable left get_config reaching _get_secret
unguarded, so the helper's claim that such an id is refused for every lookup was
no longer true. Not a cross-team read -- get_config never receives a team_name 
--
but the two getters and the docstring disagreed with the third.

Guard get_config too, and correct the docstring to name the three getters.

_names_a_team_namespace uses no instance state, so it becomes a staticmethod.

The refusal-logging test asserted on the rendered sentence. Airflow logs through
structlog, which renders format args into msg before the stdlib record exists, 
so
record.args is empty and there is no structured payload to assert on; assert on
level, logger and the refused id instead, which is what the test is actually
about, and extend it to cover get_config.

Report URL: https://github.com/apache/airflow/actions/runs/30695560925

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to