The GitHub Actions job "Tests (AMD)" on 
airflow.git/repair-the-refusal-log-assertions-on-main has succeeded.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
8be8fed3470c6695d323595b39acf649067e5ef4 / Jarek Potiuk <[email protected]>
Assert the refusal log with getMessage so the compat tests pass

The refusal-logging assertions in the Amazon secrets tests read record.msg
directly. How a record carries its payload depends on the Airflow version: on
main, structlog renders the format args into msg before the stdlib record 
exists,
so args is empty and msg holds the final text; on the versions the provider
compat tests run against, plain stdlib logging leaves msg as the format string
with the values in args.

Reading msg therefore passes on main and fails under Compat 2.11.1 and 3.0.6,
which is where these currently break:

  assert 0 == 1
  where 0 = sum(refused_id in r.msg for r in refusals)

getMessage() renders in both shapes. The assertion still targets the refused id
rather than the wording, so rephrasing the warning stays free.

Introduced in #70878, where the assertions were moved off getMessage and 
verified
only against main.

Report URL: https://github.com/apache/airflow/actions/runs/30701141789

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to