The GitHub Actions job "Tests (AMD)" on airflow.git/fix/grid-structure-idle-in-tx-65712 has succeeded. Run started by GitHub user seanmuth (triggered by seanmuth).
Head commit for run: 4aef9fa7899447278f184cd4e4f3e9786b443ef7 / seanmuth <[email protected]> Address review: trim comment, drop unnecessary order_by, use session.close() - Comment above serdag_id_query was too verbose for a simple query; the rationale belongs in the commit message. Trimmed per dstandish's suggestion. - Dropped .order_by(SerializedDagModel.id): the original code had no explicit ordering, and _merge_node_dicts is sensitive to processing order for nodes that differ across historical Dag versions, so this restores exact prior behavior instead of introducing an unreviewed ordering guarantee. - Replaced session.commit() with session.close(): this session has done no writes (pure read), so close() is the more accurate call and, per review, reads clearer while releasing the connection the same way. Report URL: https://github.com/apache/airflow/actions/runs/31409414878 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
