The GitHub Actions job "Tests (AMD)" on airflow.git/remove-react-fc has succeeded. Run started by GitHub user ryanahamilton (triggered by ryanahamilton).
Head commit for run: 0c097df58ee5fcad0b8e8b0f51215d8003a5c519 / Ryan Hamilton <[email protected]> UI: Stop using React.FC and the React type namespace React.FC adds nothing over annotating the props parameter directly, and the UI packages were split between the two styles. All of them compile with the automatic JSX runtime, so no file needs a React import at all -- the namespace survived only as habit. ESLint now rejects both patterns so they cannot creep back in. Two rules are needed rather than one: @types/react declares `export as namespace React`, so `React.FC` type-checks in files that never import React, and banning the import alone would miss those. src/main.tsx keeps its namespace import -- it republishes the host's React to UMD-bundled plugins, which resolve it through a `React` global. Report URL: https://github.com/apache/airflow/actions/runs/31728740109 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
