The GitHub Actions job "Tests" on airflow.git has failed.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
8ea77a5980dea0ffe0ad5928db6bcdff636aadce / Jarek Potiuk <[email protected]>
Fix coertion for VERBOSE and DRY_RUN env variables (#27366)

The #27191 change introduced globally shareable flags for verbose
and dry-run flags in Breeze however it also changed behaviour of
the "false" string passed by VERBOSE/DRY_RUN env variables and
crashed breeze when one of those variables was set to empty string.

As a result CI's "VERBOSE" "false" flag in static checks was
treated as "truthy" and static checks output contained a lot of
noise from non-failing static checks.

It turns out that "convert" method of click can also take "strings"
as parameter because coertion of env variables happens inside the
convert method (which mkes sense if you think about it) so the
convert method should accept both string and target type values,
This is explained in convert method docs but I missed it :(.

This change fixes both problems by introducing explicit coertion
of the variables from all kinds of string values - both when the
flags are parsed but also before (sometimes we need verbose flag
from variable (when we run breeze in scripts) even before the
flag is actually parsed by click so additionally to coercing the
flag, we also pre-emptively run the same coertion when importing
the "shared_options" module.

Also just for the sake of it, we accept all kinds of truth-y,
falsy strings now - true/false/yes/no/t/f/y/n in all kinds of
casing and shortcuts.

Report URL: https://github.com/apache/airflow/actions/runs/3352456753

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to