The GitHub Actions job "Tests" on airflow.git has failed.
Run started by GitHub user dstandish (triggered by dstandish).

Head commit for run:
228c328c7728f8cbd5f94212131f747ae793b114 / Daniel Standish 
<[email protected]>
Fix log tailing issues with legacy log view

Probably we should just chop this view in favor of grid view logging which is 
the future. But this fixes rendering issues raised here 
https://github.com/apache/airflow/pull/29447#issuecomment-1424981137.

What we do, is in log tailing context (which apparently isn't used in grid, and 
that's why I did not see this in developing trigger logging) we don't add the 
messages to the log content.  So, whenever log_pos is in metadata we don't add 
messages.  It means the messages could be a bit stale but that seems ok.  
Refreshing the page could fix that.  Longer term, we could update the API so 
that log content is just content and the messages are themselves returned in 
the metadata dict.  That's probably the "right" solution ultimately.  But can 
be saved for another day.  Also resolve the "cannot load lazy instance" issue 
when invoking the reader logic from this different context.

Report URL: https://github.com/apache/airflow/actions/runs/4158384662

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to