The GitHub Actions job "Tests" on airflow.git has failed.
Run started by GitHub user ephraimbuddy (triggered by ephraimbuddy).

Head commit for run:
7536737e23c944ffacb9b737ddf047a56341ae99 / Jarek Potiuk <[email protected]>
Attempt to fix the flaky TestTriggererJob test (#34075)

As documented in #33323, we have frequent failures of the flaky
triggerer job tests.

The flaky failures are about some errors when we close all the
sessions in teardown of the test. It turns out that the tests
had side-effect - they have not waited for the TriggererJob thread
to complete, they merely marked them to be stopped, but they have
not waited for those to complete - this is quite plausible
explanation of the flaky test failures - since those threads have
1 second sleep, it's more than likely that the session has been
created and used by the thread while the teardown has been attempting
to close all the sessions.

This side effect could also have an effect for other tests that
were run after - because in a busy test run machine, the side
effects could propagate further than just to the teardown, so it
could also explain why sometimes (very rarely) other job tests
failed with similar errors.

The fix is to join the runner after marking it to be stopped.

Fixes: #33323 (Hopefully)
(cherry picked from commit 47f79b9198f3350951dc21808c36f889bee0cd06)

Report URL: https://github.com/apache/airflow/actions/runs/6075349647

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to