The GitHub Actions job "Tests" on airflow.git has failed. Run started by GitHub user potiuk (triggered by potiuk).
Head commit for run: e9d99d8463a97b19c456f27e67edb9090d9a841b / Jarek Potiuk <[email protected]> Consolidate environment variable calculation in ShellParams in Breeze Historically (when moved from Bash) the environment variables set for docker or docker-compose commands were set in a few places - some were set directly in the code, some were retrieved from shell params and eventually some were set from default values or hardcoded constants. This all happened in various models and it was scattered around the code and it was difficult to grasp what was going on. This PR consolidates it so that all variables are set in ShellParams object. * the attributes have been reviewed and None/"" default values were set where needed * the attributes were sorted * calculation of dynamic properties was moved to ShellParams * missing properties were added to ShellParams, so that all variables have corresponding properties * the get_env_variables_for_docker_commands is now a method in ShellParams object, mapping is done explicitly from self.ATTRIBUTE and default values if not set are set in this single place if not set in case the variables are are retrieved from elsewhere * we use ShellParams in all places where we execute docker commands (we used BuildCiParams) sometimes needlessly * tests are added to cover the "attribute" + "incoming env var" to the env vars passed to Docker Compose/Docker Most importantly the docker and docker-compose env files are now automatically generated and git-ignored so that we only need to maintain the list of variables to pass in a single plase - in ShellParams `env_variables_for_docker_commands` method. Report URL: https://github.com/apache/airflow/actions/runs/6969297459 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
