The GitHub Actions job "Tests" on airflow.git has failed.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
4f68a1e0ffc5abcad8fbee5e5dedf4d5f15a3f5f / Jarek Potiuk <[email protected]>
Refactor and simplify breeze-based pre-commits

Some of our pre-commits were using code from Breeze in rather complex
way - by inserting PYTHONPATH and importing code from there. That was
complex and brittle and with recent changes of ShelParam #35801 those
precommits required more and more dependencies to be added to their
pre-commit virtualenvs.

The reason that it was done this way was the assumption that someone
might want to run pre-commits locally without having breeze installed,
but this assumption and use case is rather unlikely, becasue breeze
becomes more and more useful and used so we can safely assume that
anyone who wants to do pre-commits will also have breeze installed and
on path. And anyway to run those pre-commits you need to have breeze
CI image pulled and built, so you should generally have breeze to run
them.

This PR switches for those pre-commits to utilize `breeze shell`
command to run the scripts inside the image. That requires a few
new switches in breeze shell to allow to disable diagnostics /
interactive information, automated image upgrade and forcing terminal
allocation (when running the command as git pre-commit, there is
no terminal and we need to force pseudo-terminal allocation for
docker-compose).

The pre-commit code has been refactored to make use of common
pre-commit module we already have.

As a bonus MyPy output is now coloured (also when run as part of
git commit).

Report URL: https://github.com/apache/airflow/actions/runs/6986256286

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to