The GitHub Actions job "Tests" on airflow.git has failed.
Run started by GitHub user eladkal (triggered by eladkal).

Head commit for run:
89d2f2992f4d2c0845328c2aae50c71803bf51e5 / RichieSK 
<[email protected]>
Warn user about unused replace parameter in insert_rows (OracleHook) (#39408)

* Remove unused replace boolean parameter in insert_rows function of OracleHook 
class

The replace boolean parameter claims to replace rows instead of insert, but 
this functionality has not been implemented and the documentation claims it 
works. This can be misleading to any user of this class. Furthermore, the 
parameter isn't even being used anywhere in this function.

In this commit, I removed the parameter to prevent any confusion amongst the 
users of this class.

* Clarified usage of replace parameter in insert_rows

Re-introduced the replace boolean parameter.
Added a warning when the user sets the replace parameter to True.
Updated the docstring to let the user know that the replace boolean parameter 
does nothing.

* Updated formatting of warning in insert_rows

Updated the formatting of warning to increase readability.

* Update oracle.py

Switched back to original description of replace parameter with a warning of no 
current implementation

* Format Fix

Added a format fix to pass static format testing

Report URL: https://github.com/apache/airflow/actions/runs/9805253433

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to